fix(android): ensure deterministic cipher selection - #795
Open
kewdex wants to merge 4 commits into
Open
Conversation
Use LinkedHashMap to preserve cipher insertion order and change capability comparison to prefer first match when equal. This ensures AES-GCM is consistently selected over RSA for new biometric credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Previously, cipher selection used HashMap which has non-deterministic iteration order. When two ciphers had equal capability (AES-GCM and RSA both at 1023), the selected cipher depended on hash bucket ordering, potentially causing inconsistent behavior across devices/installs.
Solution
HashMaptoLinkedHashMapto preserve insertion order<to<=so first match winsTest plan