fix: extract hardlinked files that share inodes - #514
Open
dyk1454683243-sudo wants to merge 2 commits into
Open
dyk1454683243-sudo wants to merge 2 commits into
dyk1454683243-sudo wants to merge 2 commits into
Conversation
The extract filter skipped every node-tar type ending in Link, so regular files packed as type Link (nlink > 1) were dropped. Skip only SymbolicLink and keep hardlink entries so extract does not depend on shared inodes. Fixes npm#285 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Keep the directory-fetcher hardlink regression and the existing weird-pkg extract assertions for Link vs SymbolicLink. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285
Cause
FetcherBaseextract uses a node-tarfilterthat skipped every entry whose type matched/Link$/. That matches bothSymbolicLinkandLink.node-tar marks a regular file as type
Linkwhennlink > 1(the first path is written asFile; later paths that share the inode are hardlink entries with no file body). Directory installs andtarballStream/extracttherefore dropped every hardlinked copy, so the extracted tree depended on whether source files happened to share inodes.Fix
Skip only
SymbolicLink. KeepLinkentries (hardlinked regular files) and apply the same file mode /.gitignorehandling asFileentries. node-tar already strips thepackage/prefix from hardlinklinkpathwhenstrip: 1, so those entries extract as files in the destination.Tests
index.jsanddist/index.jsshare an inode; both files are present with the same content.weird-pkgfixture:index-hardlink.jsis now kept (and remains a hardlink toindex.js);index-symlink.jsremains excluded.