Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/interceptor/decompress.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,10 @@ function createDecompressInterceptor (options = {}) {

return (dispatch) => {
return (opts, handler) => {
if (opts.method === 'HEAD') {
return dispatch(opts, handler)
}

const decompressHandler = new DecompressHandler(handler, options)
return dispatch(opts, decompressHandler)
}
Expand Down
44 changes: 42 additions & 2 deletions test/interceptors/decompress.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
const { test, after } = require('node:test')
const { createServer } = require('node:http')
const { once } = require('node:events')
const { createGzip, createDeflate, createBrotliCompress, createZstdCompress } = require('node:zlib')
const { createGzip, createDeflate, createBrotliCompress, createZstdCompress, gzipSync } = require('node:zlib')
const { tspl } = require('@matteo.collina/tspl')

const { Client, getGlobalDispatcher, setGlobalDispatcher, request } = require('../..')
const { Client, getGlobalDispatcher, setGlobalDispatcher, request, interceptors } = require('../..')
const createDecompressInterceptor = require('../../lib/interceptor/decompress')

test('should decompress gzip response', async t => {
Expand Down Expand Up @@ -51,6 +51,46 @@ test('should decompress gzip response', async t => {
await t.completed
})

test('should preserve representation headers and empty body for HEAD responses', async t => {
const compressedRepresentation = gzipSync('HEAD response representation')
const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
res.writeHead(200, {
'Content-Type': 'text/plain',
'Content-Encoding': 'gzip',
'Content-Length': compressedRepresentation.length
})
res.end()
})

server.listen(0)
await once(server, 'listening')

const client = new Client(
`http://localhost:${server.address().port}`
).compose(interceptors.decompress())

after(async () => {
await client.close()
server.close()
await once(server, 'close')
})

t = tspl(t, { plan: 4 })

const response = await client.request({
method: 'HEAD',
path: '/'
})
const body = await response.body.text()

t.equal(response.statusCode, 200)
t.equal(response.headers['content-encoding'], 'gzip')
t.equal(response.headers['content-length'], `${compressedRepresentation.length}`)
t.equal(body, '')

await t.completed
})

test('should decompress deflate response', async t => {
t = tspl(t, { plan: 3 })

Expand Down
Loading