Skip to content

ci: build undici with node.js v26#5237

Merged
metcoder95 merged 2 commits into
nodejs:mainfrom
shivarm:build-node26
Jul 16, 2026
Merged

ci: build undici with node.js v26#5237
metcoder95 merged 2 commits into
nodejs:mainfrom
shivarm:build-node26

Conversation

@shivarm

@shivarm shivarm commented May 6, 2026

Copy link
Copy Markdown
Contributor

build with new node v26

@codecov-commenter

codecov-commenter commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.47%. Comparing base (4910410) to head (f5596e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5237      +/-   ##
==========================================
+ Coverage   93.44%   93.47%   +0.02%     
==========================================
  Files         110      110              
  Lines       37438    37438              
==========================================
+ Hits        34984    34994      +10     
+ Misses       2454     2444      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shivarm

shivarm commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

failure is related bcoe/c8#592

@mcollina should i skip test coverage on node.js 26? or wait for the issue to be fixed.

@mcollina

mcollina commented May 6, 2026

Copy link
Copy Markdown
Member

we can wait a few days

@shivarm

shivarm commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

We have this option to fix ci for now or we should still wait...?

"overrides":{
  "yargs": "^18.0.0"
},

@shivarm
shivarm force-pushed the build-node26 branch 2 times, most recently from 76a5acc to 03c6370 Compare June 14, 2026 15:45
@mcollina

Copy link
Copy Markdown
Member

I dont think the yargs change is needed anymore, can you verify?

@shivarm

shivarm commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@mcollina They have released c8 new version which contain latest yargs https://github.com/bcoe/c8/releases/tag/v12.0.0 but on npm registry I can't see and here you can find discussion bcoe/c8#592 (comment)

@shivarm

shivarm commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Actually my bad, I verify on npm that this is not a stable release but upgrade c8 dep let's see

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shivarm added 2 commits July 16, 2026 12:30
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@shivarm

shivarm commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

rebased

@metcoder95
metcoder95 merged commit a9bcd5e into nodejs:main Jul 16, 2026
38 checks passed
@shivarm
shivarm deleted the build-node26 branch July 16, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants