ci: build undici with node.js v26#5237
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
==========================================
+ Coverage 93.44% 93.47% +0.02%
==========================================
Files 110 110
Lines 37438 37438
==========================================
+ Hits 34984 34994 +10
+ Misses 2454 2444 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
failure is related bcoe/c8#592 @mcollina should i skip test coverage on node.js 26? or wait for the issue to be fixed. |
|
we can wait a few days |
|
We have this option to fix ci for now or we should still wait...? "overrides":{
"yargs": "^18.0.0"
}, |
76a5acc to
03c6370
Compare
|
I dont think the yargs change is needed anymore, can you verify? |
|
@mcollina They have released c8 new version which contain latest yargs https://github.com/bcoe/c8/releases/tag/v12.0.0 but on npm registry I can't see and here you can find discussion bcoe/c8#592 (comment) |
|
Actually my bad, I verify on npm that this is not a stable release but upgrade c8 dep let's see |
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
|
rebased |
build with new node v26