url: preserve property order in URLPattern results - #64735
Open
Archkon wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
Archkon
marked this pull request as draft
July 25, 2026 10:38
anonrig
reviewed
Jul 26, 2026
Use each compiled component's group name list when materializing URLPattern capture groups instead of iterating an unordered map. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Contributor
Author
|
@anonrig Could you review this again? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64735 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 744 744
Lines 242542 242555 +13
Branches 45694 45690 -4
==========================================
+ Hits 218637 218638 +1
+ Misses 15393 15387 -6
- Partials 8512 8530 +18
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 2, 2026
anonrig
approved these changes
Aug 2, 2026
Contributor
Author
|
@anonrig A regression test for capture group declaration order is already included in test/parallel/test-urlpattern.js. Could you clarify which additional case you would like covered? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64734