doc: fix typo in embedding.md#64425
Merged
Merged
Conversation
Signed-off-by: greenhead <shren0812@gmail.com>
nodejs-github-bot
added
doc
lpinca
approved these changes
Jul 11, 2026
daeyeon
approved these changes
Jul 12, 2026
trivikr
added
the
author ready
jasnell
approved these changes
Jul 12, 2026
Contributor
Author
|
Friendly ping. This is my first contribution here. It has two approvals and the |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3c88785 |
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64425 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64425 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo:
Setup up→Set upindoc/api/embedding.md(the C++ embedder API example).Set upis the correct verb form (setupis the noun/adjective form), and it also matches the existing wording a few lines above: "In order to set up av8::Isolate".