vfs: enforce readonly state on open handles#64403
Open
harjothkhara wants to merge 1 commit into
Open
Conversation
Signed-off-by: harjoth <harjoth.khara@gmail.com>
Author
|
Tested this end to end. Before the fix: the example from #64401 still writes to the file after it's set read-only — bug confirmed. After the fix: that write is blocked with Other write paths (truncate, append, write streams) are blocked too, and read-only handles still give the original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryProvider.setReadOnly()prevented new writable handles from being opened,but handles opened before the transition retained write access. This allowed
descriptor-based writes and truncation to bypass the provider's documented
read-only state.
Pass a live provider-state callback to
MemoryFileHandleand check it at eachmutation primitive. This covers descriptor and direct-handle operations,
including delegated async, vector, and append-mode writes, while preserving
EBADFprecedence for handles that were not opened for writing.Regression tests cover:
writeSync()andftruncateSync()through pre-existing descriptorssetReadOnly()write(),writeFile(),truncate(), andwritev()Validation:
python3 tools/test.py test/parallel/test-vfs-memory-provider.js test/parallel/test-vfs-memory-file-handle.jsFixes: #64401