Skip to content

net: multiple dtls improvements#64314

Open
jasnell wants to merge 12 commits into
nodejs:mainfrom
jasnell:jasnell/dtls-fixes
Open

net: multiple dtls improvements#64314
jasnell wants to merge 12 commits into
nodejs:mainfrom
jasnell:jasnell/dtls-fixes

Conversation

@jasnell

@jasnell jasnell commented Jul 6, 2026

Copy link
Copy Markdown
Member

Multiple DTLS improvements.

Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Claude/Opus

@jasnell jasnell requested a review from mcollina July 6, 2026 03:40
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 6, 2026
@jasnell jasnell requested a review from Qard July 7, 2026 04:10
@nodejs-github-bot

This comment was marked as outdated.

@jasnell jasnell changed the title net: improve dtls cert verification net: multiple dtls improvements Jul 7, 2026
@jasnell jasnell force-pushed the jasnell/dtls-fixes branch from 7d55980 to fe3087b Compare July 7, 2026 05:17
jasnell added 11 commits July 6, 2026 22:21
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Claude/Opus
@jasnell jasnell force-pushed the jasnell/dtls-fixes branch from fe3087b to 9953529 Compare July 7, 2026 05:21
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as duplicate.

Signed-off-by: James M Snell <jasnell@gmail.com>
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (d7aca7e) to head (d7ecfc4).
⚠️ Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64314      +/-   ##
==========================================
- Coverage   92.05%   90.25%   -1.80%     
==========================================
  Files         381      741     +360     
  Lines      169394   240795   +71401     
  Branches    25970    45350   +19380     
==========================================
+ Hits       155935   217340   +61405     
- Misses      13169    15045    +1876     
- Partials      290     8410    +8120     
Files with missing lines Coverage Δ
lib/internal/dtls/dtls.js 100.00% <100.00%> (ø)

... and 486 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants