Skip to content

http: reject addTrailers after finish#62832

Open
islandryu wants to merge 1 commit intonodejs:mainfrom
islandryu:fix-addtrailers-after-finish
Open

http: reject addTrailers after finish#62832
islandryu wants to merge 1 commit intonodejs:mainfrom
islandryu:fix-addtrailers-after-finish

Conversation

@islandryu
Copy link
Copy Markdown
Member

@islandryu islandryu commented Apr 19, 2026

Fixes: #62809

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 19, 2026

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Apr 19, 2026
@islandryu islandryu force-pushed the fix-addtrailers-after-finish branch from b054c33 to aa9f6c0 Compare April 19, 2026 14:04
@islandryu islandryu force-pushed the fix-addtrailers-after-finish branch from aa9f6c0 to 265df15 Compare April 19, 2026 14:34
@ChALkeR ChALkeR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (d7e4108) to head (265df15).
⚠️ Report is 845 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62832      +/-   ##
==========================================
+ Coverage   88.54%   89.67%   +1.12%     
==========================================
  Files         703      706       +3     
  Lines      208544   218226    +9682     
  Branches    40225    41777    +1552     
==========================================
+ Hits       184648   195685   +11037     
+ Misses      15903    14457    -1446     
- Partials     7993     8084      +91
Files with missing lines Coverage Δ
lib/_http_outgoing.js 95.80% <100.00%> (+0.11%) ⬆️

... and 419 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 19, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72789/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 19, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72793/

@islandryu islandryu added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@pimterry pimterry pimterry approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue Add this label to land a pull request using GitHub Actions. errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a check to not allow addTrailers on an already ended http reply

7 participants

@islandryu @nodejs-github-bot @mcollina @ShogunPanda @pimterry @bjohansebas @ChALkeR