Repository navigation
ci: run the benchmarks as their own check - #4
Merged
Merged
Conversation
The benchmark job runs on the same triggers as the test job. It is a smoke test of the benchmarks themselves, not an assertion on any performance numbers, with a timeout to keep a hung benchmark from burning CI minutes. Signed-off-by: Bryan English <bryan.english@datadoghq.com>
bengl
marked this pull request as ready for review
October 23, 2026 20:53
jsumners-nr
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a benchmark job to CI alongside the test job, on the same triggers: every push to every branch and every pull request.
The benchmark check is a smoke test. It verifies the benchmarks run on the current Node.js release, since node:bench is experimental and its API can move, but it does not assert any performance numbers. The job carries a 10-minute timeout so a hung benchmark cannot burn CI minutes.