fix: SetLogic methods now mirrors Set signature#5
Merged
Conversation
Member
Yeah, I actually wanted to add it yesterday :D because I thought tabs might be unusual if someone wants to contribute, I'll look at it today. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Thanks for the PR btw, looks good! I'll tag the version probably around midnight (UTC). |
delacry
added a commit
that referenced
this pull request
May 30, 2026
fix: SetLogic methods now mirrors Set signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion on #3, some
SetLogicmethods does not mirrorSetsignatures which brings static analysis error when using them:mapmapNotNullflapMapThis PR fixes the 3 method's signatures.
@delacry As a side note: it would be great to have an editorconfig / linting tool like Mago, because I had trouble not breaking the codestyle and keeping the tab indentation 😄