Conversation
…tServersAsync, closeServers)
…nto test_utils.js - Move requestAndConcat (string result) to test_utils.js - Add readUrl (Buffer result) for binary/charset-sensitive comparisons - Remove duplicate getServersAsync, closeServers, request helpers from short_response_spec.js, unblocker_spec.js, charset_spec.js, websockets_spec.js - Standardize cleanup: use closeServers in websockets_spec instead of servers.kill() callback directly - All 42 tests pass
- Restore two lost TODO comments in unblocker-client-spec.js - Add deprecation notice to legacy callback-based getServers() - Minor formatting fixes in metarobots_spec.js and websockets_spec.js
Restore four missing comments that were lost during tap→node:test migration: - metarobots_spec.js: comment explaining why assertion is commented out - unblocker_spec.js: comments for express req.protocol and trailing / handling - urlprefixer_spec.js: technical note about recursive process.nextTick warning
async.series doesn't return a Promise, so awaiting it directly would hang. Wrap in Promise with resolve/reject based on callback.
nfriedly
marked this pull request as ready for review
August 25, 2026 21:10
getServers was migrated to async/await in performance.js and is no longer used anywhere. Inlined its logic directly into getServersAsync and removed the dead callback-based wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a vulnerability and gets us down to one less dependency. Initially vibed by copilot, but it used up my entire month's allotment of tokens before finishing the job, so I did a bit by hand, then decided to try out a local agent to finish the job.