Repository navigation
Conversation
Nextcloud loads the entries with a ?v= query, while chunks import each other by plain relative paths. Rollup kept code shared with lazy chunks inside the entry chunks, so loading such a chunk fetched the entry again under a second URL and ran it twice. On the recording page this mounted two whiteboards, and the recording bot could follow one that was not shown, so recordings failed or stayed empty. Strict entry signatures make Rollup move that shared code out of the entries, which leaves them as facades that no chunk imports. Refs #1439 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1439
Nextcloud loads
whiteboard-main.mjs?v=…, but lazy chunks imported shared code from./whiteboard-main.mjswithout the query. The browser loaded that as a second module, so the main script ran twice. On the recording page this mounted two whiteboards, and the recording bot sometimes followed the one that wasn't on screen: the recording failed or showed an empty board.whiteboard-viewer.mjshad the same problem on Nextcloud 36.With
preserveEntrySignatures: 'strict', Rollup moves the shared code out of the entries, so no chunk imports an entry anymore.Tested with a bundle test that fails on main, where 50 chunks import an entry. The viewer init script still loads no React. On Nextcloud 31 the recording page and Files load
whiteboard-main.mjsonce, and boards open in the viewer.AI