Skip to content

refactor: remove @nextcloud/initial-state@2 usage#1793

Merged
ShGKme merged 4 commits into
mainfrom
refactor/remove-loadState
Jul 6, 2026
Merged

refactor: remove @nextcloud/initial-state@2 usage#1793
ShGKme merged 4 commits into
mainfrom
refactor/remove-loadState

Conversation

@ShGKme

@ShGKme ShGKme commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Currently, the initial state is used only for notifications app settings (like in the original app)
  • App mutates initial state on settings and user status change
  • Mutating the initial state is not compatible with the latest @nextcloud/initial-state
  • Instead of sharing the state via initial state, computing it on the only place it is actually needed.

For testing:

  1. Enable dev mode
  2. Open any conversation
  3. Use Show Call Popup and listen for the sound depending on settings and user status
image

ShGKme added 4 commits July 3, 2026 22:30
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested a review from Antreesy July 3, 2026 20:30
@ShGKme ShGKme self-assigned this Jul 3, 2026
@ShGKme ShGKme added dependencies technical debt Maintenance and refactoring labels Jul 3, 2026
@ShGKme ShGKme enabled auto-merge July 3, 2026 22:31

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against stable33

@ShGKme ShGKme merged commit 3a75f99 into main Jul 6, 2026
12 checks passed
@ShGKme ShGKme deleted the refactor/remove-loadState branch July 6, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies technical debt Maintenance and refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants