Extend portId rules - #3270
Merged
Merged
Extend portId rules#3270
Conversation
…alti/npm-topology
…nitions into alti/npm-topology
…alti/npm-topology
…nitions into alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
…alti/npm-topology
entityBot
approved these changes
Sep 30, 2026
entityBot
left a comment
entityBot
left a comment
Collaborator
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
vlopeziglesias
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing portId in a limited scope, expand its usage to have a more robust system
Checklist
identifierwill be unique and valid.