Updated DB rules for oracle, mysql, mssql and postgres - #3264
Conversation
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
…dd stg upstream fallback
… upstream fallback rules
…ss/port missing The metric, log, and DbServer-prefixed synthesis rules for INFRA-MYSQLNODE identify/name by a server.address:server.port composite. mysqlreceiver builds without the useOTelSemconv gate don't emit those attributes, only the derived mysql.instance.endpoint, so those entities would go unsynthesized. Guards the composite rules with server.address/server.port present:true, and adds a fallback rule per event path (metric, log, DbServer) that matches when server.address is absent and identifies/names by the older mysql.instance.endpoint attribute instead. Staging and prod. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…n composite rules
…RSP pipeline rules - Add sqlserver.target.host present:false to nrfork fallback metric rule - Add nrfork log rules with sqlserver.target.host composite identifier - Add NRSP db_server_events rules (host.name, service.instance.id, composite) - Add sqlqueryreceiver composite identifier rule - Remove generic sqlserverreceiver log/metric rules from prod
…omposite identifier rules
…allback fix(mysqlnode): fallback to mysql.instance.endpoint when server.address/port missing
Dismissing reviews
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
feat(mssql): Update Staging rules to Prod env
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- No valid, approved ARB ticket found in the PR description. This PR has to be reviewed by the API Review Board, please include a link to the ticket of that review in the PR description. Check how to start the process here or reach
#api-review-boardchannel in case of doubts
fix(postgresqlinstance): guard server.address/port composite rules, add stg upstream fallback
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- ARB tickets not approved: NR-624118 (Status: Backlog).
The review process is not handled by Entity Platform, reach#api-review-boardchannel in case of doubts
| field: hostAddress | ||
| - tagKeys: ["host.port"] | ||
| field: hostPort | ||
| - tagKeys: ["server.address"] |
There was a problem hiding this comment.
Are you sure this is working for old oracle binaries? The rule infra_oracledbinstance_host_name_nrfork does not generate server.x
There was a problem hiding this comment.
@sseif-nr The relation can be established using the shared endpoint tag, see relationships/synthesis/APM-APPLICATION-to-DATABASE.yml's apmCallsGenericDatabase rule, which matches Oracle Datastore metrics via the generic DATABASE candidate category on the endpoint tag key, so both old-binary (host.address) and new-binary (server.address) entities remain reachable there. As a manual fallback, tags can also be added directly to an entity to satisfy a candidate match if needed.
| entityTagName: instrumentation.name | ||
| otel.library.version: | ||
| entityTagName: instrumentation.version | ||
| server.address: |
There was a problem hiding this comment.
Line 66 states that this attribute cannot be present.
There was a problem hiding this comment.
@sseif-nr Removed these tags as those are not being used
fix: dashboard update
Dismissing reviews
|
No concerns from the API side with it. The final ack needs to come from an EP engineer to assert technical sanity. |
@sseif-nr In that case, would you approve this PR. so we can move forward with EP team |
Dismissing reviews
Relevant information
Rolls out server.address/server.port to prod as the entity identifier for ORACLEDBINSTANCE, MYSQLNODE, POSTGRESQLINSTANCE, and MSSQLINSTANCE, with each DB type falling back to its existing legacy identifier for customers still on older receiver binaries. This keeps entity creation consistent across old and new binary versions.
ARB Jira ticket:
https://new-relic.atlassian.net/browse/NR-624118
Checklist
identifierwill be unique and valid.