fix: Allow to connect using host name if IP address was not discovered#73
Open
railbox wants to merge 1 commit into
Open
fix: Allow to connect using host name if IP address was not discovered#73railbox wants to merge 1 commit into
railbox wants to merge 1 commit into
Conversation
Owner
|
Thank you for your PR. I'll need to think about this... don't know if delegating the mDNS IP resolution to the DNS server is a good plan or if it would be better to just re-query, and if this is the place in the code to do it. Heiko P.S: Also can you remove the whitespace changes from this PR? Feel free to add another one for just the whitespace changes, but I prefer to keep formatting changes away from functional ones. |
Author
|
Spaces removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the mDNS library return discovered IP as 0.0.0.0 which do not allow for direct connection. This fix allow in this case to connect using hostname so the library will try to resolve IP address again