Skip to content

fix: Allow to connect using host name if IP address was not discovered#73

Open
railbox wants to merge 1 commit into
newHeiko:masterfrom
railbox:mDNS-fix
Open

fix: Allow to connect using host name if IP address was not discovered#73
railbox wants to merge 1 commit into
newHeiko:masterfrom
railbox:mDNS-fix

Conversation

@railbox

@railbox railbox commented Apr 19, 2026

Copy link
Copy Markdown

In some cases the mDNS library return discovered IP as 0.0.0.0 which do not allow for direct connection. This fix allow in this case to connect using hostname so the library will try to resolve IP address again

@newHeiko

Copy link
Copy Markdown
Owner

Thank you for your PR.

I'll need to think about this... don't know if delegating the mDNS IP resolution to the DNS server is a good plan or if it would be better to just re-query, and if this is the place in the code to do it.

Heiko

P.S: Also can you remove the whitespace changes from this PR? Feel free to add another one for just the whitespace changes, but I prefer to keep formatting changes away from functional ones.

@railbox

railbox commented May 13, 2026

Copy link
Copy Markdown
Author

Spaces removed.
Generally I had issue with our command station that the mDNS response return 0.0.0.0 in the WiFred. Re-running the resolution solves the problem with the connection.
Tried to debug our command station from Android App/PC and there resolution worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants