Skip to content

[MNT] Remove deprecated orjson dependency - #268

Merged
alyssadai merged 1 commit into
mainfrom
remove-orjson
Sep 3, 2026
Merged

[MNT] Remove deprecated orjson dependency#268
alyssadai merged 1 commit into
mainfrom
remove-orjson

Conversation

@alyssadai

@alyssadai alyssadai commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

Remove the deprecated orjson dependency from the application and project configuration.

Enhancements:

  • Remove the deprecated orjson dependency and use FastAPI's standard response handling.

Build:

  • Update project dependency configuration and lockfile to eliminate orjson.

@alyssadai alyssadai added the pr-dependencies Update one or more dependencies version label Sep 3, 2026
@sourcery-ai

sourcery-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the deprecated orjson dependency by eliminating FastAPI's global ORJSON response configuration, updating project dependencies, and regenerating the UV lockfile.

File-Level Changes

Change Details Files
Remove the application-wide ORJSON response configuration so FastAPI no longer requires the deprecated serialization dependency.
  • Remove the ORJSONResponse import.
  • Remove ORJSONResponse as the FastAPI default response class.
app/main.py
Remove the deprecated dependency and normalize dependency-list formatting.
  • Delete orjson from runtime dependencies.
  • Reformat runtime and development dependency entries with consistent indentation.
pyproject.toml
Regenerate the lockfile after removing the dependency.
  • Update resolved dependency metadata and package entries to reflect the removal of orjson.
uv.lock

Assessment against linked issues

Issue Objective Addressed Explanation
#242 Regenerate uv.lock so the development dependencies reflect the switch from coverage to pytest-cov.
#267 Replace the application-wide use of FastAPI's deprecated ORJSONResponse with the default JSONResponse behavior.
#267 Remove the orjson package from the project's runtime dependencies and lockfile.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (342e419) to head (cd00681).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          26       26           
  Lines         996      996           
  Branches       59       59           
=======================================
  Hits          971      971           
  Misses         18       18           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@surchs surchs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai

🧑‍🍳

@alyssadai
alyssadai merged commit d123db1 into main Sep 3, 2026
11 checks passed
@alyssadai
alyssadai deleted the remove-orjson branch September 3, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-dependencies Update one or more dependencies version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove orjson dependency Regenerate uv.lock file with pytest-cov

2 participants