Skip to content

Add getOptions to pool_master - #302

Open
grantcarthew wants to merge 1 commit into
neumino:masterfrom
grantcarthew:getOptions
Open

Add getOptions to pool_master#302
grantcarthew wants to merge 1 commit into
neumino:masterfrom
grantcarthew:getOptions

Conversation

@grantcarthew

@grantcarthew grantcarthew commented Oct 7, 2016

Copy link
Copy Markdown

Hi @neumino,

This is a simple change so I can access the options here:
https://github.com/grantcarthew/node-rethinkdb-job-queue/blob/master/src/queue-db.js#L13-L16

The job queue supports passing a rethinkdbdash object, in which case the db, host, port etc is unknown.
At the moment I am reading the values using:

q._host = q.r._poolMaster._options.host

With this pull request I can change it to something like:

q._host = q.r.getPoolMaster().getOptions().host

Thanks mate.

@grantcarthew

Copy link
Copy Markdown
Author

Where would you want tests created @neumino ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant