Repository navigation
Fix tray hook failure by marshalling updates to UI thread - #132
Merged
Merged
Conversation
Marshal TrayIcon UI updates in OnHookFailed onto Dispatcher.UIThread to avoid Avalonia invalid thread exceptions when the hotkey hook faults on a background thread. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b4eea782-178d-4d75-9182-24b22f627186
There was a problem hiding this comment.
Pull request overview
This PR makes the tray icon’s hotkey-failure UI updates thread-safe by ensuring tooltip/menu mutations are executed on Avalonia’s UI thread, preventing InvalidOperationException when the global hook fails on a background thread.
Changes:
- Added
Avalonia.Threadingusage to marshal tray UI updates toDispatcher.UIThread. - Encapsulated tooltip and menu header mutations into a local
UpdateUiaction. - Executes updates synchronously when already on the UI thread; otherwise posts to the UI dispatcher.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When the global hotkey hook fails, the failure callback can run on a background thread. Updating Avalonia tray properties from that thread throws
InvalidOperationException: Call from invalid thread.What changed
TrayIcon.OnHookFailednow marshals tray UI updates ontoDispatcher.UIThread.Avalonia.Threadingimport.UpdateUiaction.Notes
This keeps the existing behavior and message text, but makes the failure path thread-safe.