Skip to content

TRADE-1167: Refactored grouping logic into separate function for reuse#220

Merged
kecunning merged 4 commits into
nasa:developfrom
kecunning:TRADE-1167
Jun 22, 2026
Merged

TRADE-1167: Refactored grouping logic into separate function for reuse#220
kecunning merged 4 commits into
nasa:developfrom
kecunning:TRADE-1167

Conversation

@kecunning

@kecunning kecunning commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

GitHub Issue: #215

Description

Refactored grouping logic into separate function for reuse. Updated files to use the new function and added a unit test for the new function.

Local test steps

Ran test in UAT and locally to confirm the results are the same.

Overview of integration done

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

@kecunning kecunning requested a review from ank1m June 16, 2026 11:32
@codecov-commenter

codecov-commenter commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (984a578) to head (3cd9689).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #220      +/-   ##
===========================================
+ Coverage    84.02%   84.35%   +0.32%     
===========================================
  Files            4        4              
  Lines          144      147       +3     
===========================================
+ Hits           121      124       +3     
  Misses          23       23              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kecunning kecunning merged commit e34228f into nasa:develop Jun 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants