Skip to content

CMR-11600: Update urllib3 to newer version - #2526

Merged
jceaser merged 5 commits into
masterfrom
cmr-11600-urllib
Oct 28, 2026
Merged

jceaser merged 5 commits into
masterfrom
cmr-11600-urllib

Conversation

@jceaser

@jceaser jceaser commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

Update urllib3 to newer version

  • update urllib3
  • adding a dummy test server for local development
  • fixing local tests to work with "all" hours, that is '*'

What are the changes?

The job-utilities local_development sub-project used an outdated version of urllib3 and also the test program no longer works with the latest job-details.json file when '*' was used. The test program was updated so that tickets such as this one could validate a functional project.

If you do not want too run CMR just to do basic tests in the local_scheduler.py app, you can use the new everything_is_awesome_server.py which will accept any request sent to it and respond with a 200, enough to test that the job-details.json file can be parsed and acted on.

What areas of the application does this impact?

  • job-utilities/local_development

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • pylint has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

…r for use in local tests; fixing local tests to work with all hours
@jceaser jceaser changed the title CMR-11600: Update urllib3 to newer version; adding a dummy test serve… CMR-11600: Update urllib3 to newer version Oct 26, 2026
@codecov-commenter

codecov-commenter commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.72%. Comparing base (0d355d8) to head (6e91c6d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2526      +/-   ##
==========================================
- Coverage   53.73%   53.72%   -0.01%     
==========================================
  Files        1073     1073              
  Lines       74924    74924              
  Branches     2417     2416       -1     
==========================================
- Hits        40257    40256       -1     
- Misses      32385    32387       +2     
+ Partials     2282     2281       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jceaser
jceaser marked this pull request as ready for review October 27, 2026 10:40
@jceaser

jceaser commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

already you may see that the snyk warning is gone here

Comment thread job-utilities/local_development/requirements.txt
Comment thread job-utilities/local_development/local_scheduler.py
Comment thread job-utilities/local_development/local_scheduler.py Outdated
Comment thread job-utilities/local_development/README.md
Comment thread job-utilities/local_development/README.md Outdated
@jceaser
jceaser requested a review from daniel-zamora October 27, 2026 17:04
@jceaser
jceaser merged commit 8ca5cb2 into master Oct 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants