Repository navigation
CMR-11600: Update urllib3 to newer version - #2526
Merged
Merged
Conversation
…r for use in local tests; fixing local tests to work with all hours
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
- Coverage 53.73% 53.72% -0.01%
==========================================
Files 1073 1073
Lines 74924 74924
Branches 2417 2416 -1
==========================================
- Hits 40257 40256 -1
- Misses 32385 32387 +2
+ Partials 2282 2281 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jceaser
marked this pull request as ready for review
October 27, 2026 10:40
Contributor
Author
|
already you may see that the snyk warning is gone here |
jceaser
commented
Oct 27, 2026
…more detail to logs
daniel-zamora
approved these changes
Oct 27, 2026
eereiter
approved these changes
Oct 27, 2026
jaortega527
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the objective?
Update urllib3 to newer version
What are the changes?
The job-utilities local_development sub-project used an outdated version of urllib3 and also the test program no longer works with the latest job-details.json file when '*' was used. The test program was updated so that tickets such as this one could validate a functional project.
If you do not want too run CMR just to do basic tests in the local_scheduler.py app, you can use the new
everything_is_awesome_server.pywhich will accept any request sent to it and respond with a 200, enough to test that the job-details.json file can be parsed and acted on.What areas of the application does this impact?
Required Checklist