Repository navigation
Issue #155, Use sizeof() not OS_MAX_API_NAME - #160
Merged
Merged
Conversation
The local strings in CS are not defined from OS_MAX_API_NAME Use sizeof() to get the actual size no matter how it was defined
chillfig
approved these changes
Nov 5, 2026
chillfig
left a comment
Member
There was a problem hiding this comment.
Looks like a clean fix. No concerns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: FSW Code Change
about: Flight Software code changes
labels: fsw
Description of Change
The local strings in CS are not defined from OS_MAX_API_NAME Use sizeof() to get the actual size no matter how it was defined
Linked Issue
Closes #155
Requirements Impact
Testing Evidence
Unit Tests (UT Assert)
COSMOS Test Suite
Areas of Expertise Touched
Author Checklist
.clang-formatReviewer Checklist
.clang-formathas been appliedReviewer Testing Notes