Repository navigation
Conversation
chillfig
force-pushed
the
fix-20-app-restart-checksum
branch
from
October 27, 2026 18:34
9f44fcb to
358a46d
Compare
chillfig
force-pushed
the
fix-20-app-restart-checksum
branch
from
October 27, 2026 18:47
358a46d to
40eb16b
Compare
Cameron-Sykes
self-requested a review
November 2, 2026 17:49
LuntCayden
requested changes
Nov 5, 2026
LuntCayden
left a comment
There was a problem hiding this comment.
The code looks solid. Once you address Cameron's feedback on test maintainability (extracting the magic numbers into variables and macros), this should be ready. The reload detection logic looks comprehensive and the test coverage is good.
Cameron-Sykes
approved these changes
Nov 10, 2026
Contributor
Hi @LuntCayden, I approved and feel that my issues were addressed. Can you resolve your requested change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: FSW Code Change
about: Flight Software code changes
labels: fsw
Description of Change
Resolve application and library identity and code range before each checksum chunk. On a new ES resource ID, discard partial progress and the old baseline, then report the reset through an informational event. Preserve corruption detection for unchanged instances and update results-table schemas, regression tests, and documentation.
Linked Issue
Closes #20
Requirements Impact
Testing Evidence
Unit Tests (UT Assert)
Unit test result:

New tests:
CS_ComputeApp_Test_RelocatedAppRebaseline()CS_ComputeApp_Test_RelocatedMidPassRestarts()CS_ComputeApp_Test_SameAddressReloadRestarts()CS_ComputeApp_Test_UnchangedInstanceCorruption()CS_ComputeApp_Test_UnchangedInstanceResumes()CS_ComputeApp_Test_LookupFailureThenReload()CS_ComputeApp_Test_InvalidAddressThenRecovery()CS_ComputeApp_Test_SameInstanceMappingChange()CS_ComputeApp_Test_LibraryReload()CS_RecomputeAppChildTask_Test_ReloadDuringRecompute()COSMOS Test Suite
N/A
Areas of Expertise Touched
Author Checklist
.clang-formatReviewer Checklist
.clang-formathas been appliedReviewer Testing Notes