Skip to content

sync: ensure State Vector Data Name follows SVS v3 spec #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianyuan129 merged 1 commit into from
Jul 11, 2026
+4 −2
Merged

sync: ensure State Vector Data Name follows SVS v3 spec #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions std/sync/svs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import (
"github.com/named-data/ndnd/std/utils"
)

const SvSyncVersion = 3

type SvSync struct {
o SvSyncOpts

Expand Down Expand Up @@ -135,7 +137,7 @@ func NewSvSync(opts SvSyncOpts) *SvSync {
mutex: sync.Mutex{},
state: initialState,
mtime: make(map[string]time.Time),
prefix: opts.GroupPrefix.Append(enc.NewVersionComponent(3)),
prefix: opts.GroupPrefix.Append(enc.NewVersionComponent(SvSyncVersion)),

suppress: false,
merge: NewSvMap[uint64](0),
Expand Down Expand Up @@ -480,7 +482,7 @@ func (s *SvSync) encodeSyncData() enc.Wire {
svWire := (&spec_svs.SvsData{StateVector: sv}).Encode()

// SVS v3 Sync Data
name := s.o.SyncDataName.WithVersion(enc.VersionUnixMicro)
name := s.o.SyncDataName.WithVersion(SvSyncVersion)

// Sign Sync Data
signer := s.o.Client.SuggestSigner(name)
Expand Down
Loading