Document versus rankings and finish info - #766
Merged
Merged
Conversation
MegaMech
requested changes
Jul 10, 2026
| case 7: | ||
| switch (gRaceState) { | ||
| case RACE_CURRENT: | ||
| case RACE_HAS_HUMAN_FINISHER: |
Contributor
Author
There was a problem hiding this comment.
Denotes at least 1 human has finished.
Changed it to RACE_HUMAN_FINISHED. I think HAS made it sound more like a boolean than intended.
Collaborator
There was a problem hiding this comment.
I don't mind the has, up to you on this one. I just thought the finisher was a mispelling and that the intention may have been finished
RACE_HAS_A_PLAYER_FINISHED is another alternate option...
But this is also state so maybe:
RACE_A_PLAYER_FINISHED
I'm kinda up for any of the above on this one.
MegaMech
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documenting variables and behavior related to rankings and finishing.
This was related to an investigation into port priority for versus mode, so added some comments about how that works since it is not immediately obvious by looking at the code. Roughly, player movement gets processed in player order, so if two players finish on the same frame in versus, the player with the lower port number will be processed first and get the better placement.