Skip to content

Add observer Docker build validation to CI #687

Closed

Description

@Verolop

CI runs observer tests against the full repository checkout, but does not build tools/observer/Dockerfile. This leaves missing Docker build inputs undetected.

For example, the observer imports the operator's pkg/topology package, but its Dockerfile omitted pkg/. Tests passed while make observer-build failed, also breaking make kind-deploy. PR #682 fixes that omission.

Add a single-architecture CI check that builds the observer image so similar regressions are caught before merging.

Acceptance criteria

  • Build tools/observer/Dockerfile using the repository root as the build context.
  • Run the check on pull requests and pushes to main.
  • Fail the check if the observer image cannot be built.
  • Build for one architecture, without pushing an image or requiring registry credentials.
  • Confirm the check catches the missing pkg/ failure fixed by fix(observer): copy root packages into image builder #682.

Priority

Low-priority maintenance follow-up. This adds regression coverage and is not a prerequisite for merging #682. Keep CI cost modest; a cluster deployment or multi-architecture build is not needed for this check.

Activity

  1. makinje16 commented on Sep 28, 2026

    @makinje16
    Contributor

    👋🏿 Since I authored #682 I can take on this issue

  2. Verolop commented on Sep 28, 2026

    @Verolop
    ContributorAuthor

    @makinje16 I was wondering if you'd be interested. Thank you!

  3. added a commit that references this issue on Sep 28, 2026
    b763b5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestgithub_actionsPull requests that update GitHub Actions code

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions