Skip to content

Show full server info for frequent and recent locations#367

Merged
ruihildt merged 2 commits into
mainfrom
size-updates
Jul 8, 2026
Merged

Show full server info for frequent and recent locations#367
ruihildt merged 2 commits into
mainfrom
size-updates

Conversation

@hankolsen

@hankolsen hankolsen commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Fixes #364

Allow Button component to use whitespace-normal class so the text can wrap if needed.
Update MostUsedLocationButtons and RecentLocationButtons to not truncate text and use whitespace-normal.
Update MostUsedLocationButtons and RecentLocationButtons to center the trash icon vertically.

@hankolsen hankolsen changed the title Show full server info Show full server info for frequent and recent locations Jul 7, 2026
@hankolsen hankolsen marked this pull request as ready for review July 7, 2026 15:59
@ruihildt

ruihildt commented Jul 7, 2026

Copy link
Copy Markdown
Member

I was also thinking of removing from the names wg-socks5 so for example changing al-tia-wg-socks5-001 to al-tia-001. Since it doesn't give actual information, and the context makes it pretty clear that this is proxy server we're dealing with.

image

Also relaized, we're not being consistent across the different places:

image

But maybe that's for another PR?

@hankolsen

Copy link
Copy Markdown
Collaborator Author

Updated the Location component:

image

@ruihildt

ruihildt commented Jul 8, 2026

Copy link
Copy Markdown
Member

found an unwanted side-effect in terms of buttons, and a missing update in terms of naming:

image

@hankolsen

hankolsen commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author
  1. I don't see that line break. Weird. (For me it has the whitespace-nowrap class
    <button class="btn whitespace-nowrap bg-blue text-white btn-small">Select location</button>)
  2. Would you like wg- to be removed here? (I've only removed mentions of wg-socks5-so far)

@ruihildt

ruihildt commented Jul 8, 2026

Copy link
Copy Markdown
Member
  • I don't see that line break. Weird.

It's weird, I can reproduce it only half reliably.

  • Would you like wg- to be removed here? (I've only removed mentions of wg-socks5-so far)

Yes, so it's the same information everywhere.

@hankolsen

Copy link
Copy Markdown
Collaborator Author

It's weird, I can reproduce it only half reliably.

When you can reproduce, could you check to see if the button has the class whitespace-nowrap or not?

@ruihildt

ruihildt commented Jul 8, 2026

Copy link
Copy Markdown
Member

When you can reproduce, could you check to see if the button has the class whitespace-nowrap or not?
It does.

image

@hankolsen

Copy link
Copy Markdown
Collaborator Author

Looks like the class definition is missing in your version...
Restart the dev server?

Screenshot 2026-07-08 at 14 22 05

Comment thread src/components/Proxy/CustomProxies.vue Outdated
@ruihildt

ruihildt commented Jul 8, 2026

Copy link
Copy Markdown
Member

Looks like the class definition is missing in your version... Restart the dev server?
Restarting doesn't help in those cases, I wonder if this is another case of npm vs pnpm.

Here's a binary I created, could you try it on your end and check if you also see it? (needs renaming from .txt to .xpi)

mullvad-browser-extension-0.9.11.txt

@hankolsen

Copy link
Copy Markdown
Collaborator Author

Found the issue with the missing class:
https://unocss.dev/guide/extracting#safelist

@hankolsen hankolsen force-pushed the size-updates branch 2 times, most recently from 12f1d1d to 9a73d0a Compare July 8, 2026 13:08

@ruihildt ruihildt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we're nearly there.^^"

In getRandomSessionProxy.ts (line 42) and useSocksProxy.ts (line 230), there are still leftover of the old hostname renaming, which can go entirely thanks to your change at the source in the flatProxiesList.

@hankolsen

Copy link
Copy Markdown
Collaborator Author

Nice, we're nearly there.^^"

In getRandomSessionProxy.ts (line 42) and useSocksProxy.ts (line 230), there are still leftover of the old hostname renaming, which can go entirely thanks to your change at the source in the flatProxiesList.

CTRL + F failed me…

@hankolsen

Copy link
Copy Markdown
Collaborator Author

Fixed!

@ruihildt ruihildt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop.

hankolsen added 2 commits July 8, 2026 19:55
Remove 'wg-socks5-' from ProxyList

Remove 'wg-' from Proxy tab
@ruihildt ruihildt merged commit 7c1423e into main Jul 8, 2026
4 checks passed
@ruihildt ruihildt deleted the size-updates branch July 8, 2026 17:56
@github-project-automation github-project-automation Bot moved this from Triage to Done in Mullvad Browser Extension Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Full server not visible on "Select proxy server location"

2 participants