[pickers] Prevent focus restoration from reopening picker - #23321
Open
JAYATIAHUJA wants to merge 2 commits into
Open
[pickers] Prevent focus restoration from reopening picker#23321JAYATIAHUJA wants to merge 2 commits into
JAYATIAHUJA wants to merge 2 commits into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Author
|
Follow-up on the initial browser CI failures: both Chromium jobs failed at the same immediate dialog-removal assertion while the popper exit transition was still running. I pushed 9ba4f80 to use the repository's established transition-safe Verified locally after the change:
The required PR type-label check needs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a desktop picker closes after selecting a date,
PickerPopperrestores focus to the field. WithkeepOpenDuringFieldFocus, that programmatic focus was treated as user focus and immediately reopened the picker.This change:
isRestoringFocusRefto the picker contextPickerPopperPickerFieldUIfrom reopening only during that programmatic restorationCloses #23089
Changelog
[pickers] Prevent
keepOpenDuringFieldFocusfrom reopening the picker after a selection closes it.Testing
pnpm test:unit --project "x-date-pickers" --run <affected test files> --maxWorkers=1— 39 tests passedpnpm --filter "@mui/x-date-pickers" run typescriptpnpm --filter "@mui/x-date-pickers-pro" run typescript