Pickers calendar day size token - #23315
Open
Syed-Ali-Abbas-Zaidi wants to merge 4 commits into
Open
Conversation
Syed-Ali-Abbas-Zaidi
commented
Aug 7, 2026
Syed-Ali-Abbas-Zaidi
commented
- I have followed (at least) the PR section of the contributing guide.
1 task
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
The previous approach made the calendar dimensions follow the `--PickerDay-*` variables directly, which required two breaking changes: the day slots stopped declaring the variables, and `--PickerDay-horizontalMargin` started requiring a unit because it fed a `calc()`. Instead, add a calendar-level `--PickerCalendar-daySize` token that drives the surrounding dimensions, and keep `--PickerDay-size` declared on the day sourced from it, so ancestor values reach the day while day-level overrides keep working. The grid track is derived from the day size plus a constant margin, so the margin variable never enters a `calc()` and unitless values keep working. The week rows are centered, so a margin override renders like it does today.
Syed-Ali-Abbas-Zaidi
force-pushed
the
pickers-calendar-day-size-token
branch
from
August 7, 2026 07:52
4820f7b to
627a61b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.