[data grid] Fix MissingRowIdError on cell mousedown/mouseup after row removal - #23261
Open
kareem-ib wants to merge 1 commit into
Open
[data grid] Fix MissingRowIdError on cell mousedown/mouseup after row removal#23261kareem-ib wants to merge 1 commit into
kareem-ib wants to merge 1 commit into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
kareem-ib
force-pushed
the
fix/datagrid-cell-mousedown-missingrowid-guard
branch
from
August 4, 2026 22:08
c860816 to
4fc7283
Compare
kareem-ib
force-pushed
the
fix/datagrid-cell-mousedown-missingrowid-guard
branch
from
August 17, 2026 20:52
4fc7283 to
462ea99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing
MissingRowIdErrorcrashes when a user clicks a row that has justbeen cleared from the grid's internal row list (e.g. rapid clicks under a filter that
drops the row).
The
GridCellmousedown/mouseuphandlers callgetCellParamswithout firstchecking that the row still exists. The
clickpath (publish) already guards this asit checks
getRow(rowId)and its comment explicitly notes the row may be gone("The row might have been deleted during the click").
This adds that guard to both handlers, plus a test covering click/mousedown/mouseup
after a row is removed.
Changelog
Fixed a
MissingRowIdErrorcrash when a cell received amousedown/mouseupafter itsrow had been removed from the grid.
AI-assisted (Claude Opus 4.8).