Upgrade urllib3 1.26.18 to 2.6.3#9568
Open
camd wants to merge 1 commit into
Open
Conversation
urllib3 2.x changes how gzip content-encoding is decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed content is identical — only the line-number offsets differ. Regenerated all 16 .logview.json test fixtures to match urllib3 2.x decompression behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9568 +/- ##
=======================================
Coverage 82.91% 82.91%
=======================================
Files 617 617
Lines 35681 35681
Branches 3272 3281 +9
=======================================
Hits 29584 29584
Misses 5728 5728
Partials 369 369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades urllib3
1.26.18 → 2.6.3and regenerates the log-parser test fixtures it affects.urllib3 2.x changes how gzip
Content-Encodingis decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed content is identical — only the line-number offsets differ — so all 16.logview.jsonfixtures are regenerated to match urllib3 2.x decompression behavior.Changes
requirements/common.txt:urllib3 1.26.18 → 2.6.3requirements/dev.in/requirements/dev.txt:urllib3 2.0.3 → 2.6.3(urllib3[socks])tests/sample_data/logs/*.logview.json: regenerated (16 fixtures) for urllib3 2.x line offsetsContext
This change was previously landed (#9556) and then reverted (#9562). It is intentionally kept separate from the Python 3.14 upgrade (#9324) because:
Testing
tests/log_parser/passes with urllib3 2.6.3 and the regenerated fixtures.