Skip to content

Upgrade urllib3 1.26.18 to 2.6.3#9568

Open
camd wants to merge 1 commit into
masterfrom
camd/urllib3-2.6.3
Open

Upgrade urllib3 1.26.18 to 2.6.3#9568
camd wants to merge 1 commit into
masterfrom
camd/urllib3-2.6.3

Conversation

@camd

@camd camd commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Upgrades urllib3 1.26.18 → 2.6.3 and regenerates the log-parser test fixtures it affects.

urllib3 2.x changes how gzip Content-Encoding is decompressed during streaming, which shifts line boundaries in the log parser's output. The parsed content is identical — only the line-number offsets differ — so all 16 .logview.json fixtures are regenerated to match urllib3 2.x decompression behavior.

Changes

  • requirements/common.txt: urllib3 1.26.18 → 2.6.3
  • requirements/dev.in / requirements/dev.txt: urllib3 2.0.3 → 2.6.3 (urllib3[socks])
  • tests/sample_data/logs/*.logview.json: regenerated (16 fixtures) for urllib3 2.x line offsets

Context

This change was previously landed (#9556) and then reverted (#9562). It is intentionally kept separate from the Python 3.14 upgrade (#9324) because:

  • It is independent of the Python upgrade — urllib3 1.26.18 runs fine on Python 3.14.
  • It carries a log-parser behavior change (the fixture regeneration above) that warrants review on its own rather than being buried in a runtime-version bump.

Testing

  • tests/log_parser/ passes with urllib3 2.6.3 and the regenerated fixtures.

urllib3 2.x changes how gzip content-encoding is decompressed during
streaming, which shifts line boundaries in the log parser's output. The
parsed content is identical — only the line-number offsets differ.

Regenerated all 16 .logview.json test fixtures to match urllib3 2.x
decompression behavior.
@camd camd self-assigned this May 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.91%. Comparing base (7e55a1b) to head (eb00104).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9568   +/-   ##
=======================================
  Coverage   82.91%   82.91%           
=======================================
  Files         617      617           
  Lines       35681    35681           
  Branches     3272     3281    +9     
=======================================
  Hits        29584    29584           
  Misses       5728     5728           
  Partials      369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants