Sort group leaders and members alphabetically by displayed name - #7832
Open
smithellis wants to merge 1 commit into
Open
Sort group leaders and members alphabetically by displayed name#7832smithellis wants to merge 1 commit into
smithellis wants to merge 1 commit into
Conversation
The group profile page listed leaders and members in whatever order the database returned, which also made member pagination unstable across pages. Order both lists case-insensitively by the name the page actually renders: the profile's display name when set, falling back to the username, mirroring Profile.display_name. Fixes mozilla#7270
escattone
requested changes
Sep 3, 2026
escattone
left a comment
escattone
left a comment
Contributor
There was a problem hiding this comment.
Hey Smith! I hope all is well! Sorry for the delay in getting to this, but it's been crazy busy lately. This looks great, but just needs a small change and then should be good to go. Thanks for the help!
Comment on lines
+88
to
+89
| leaders = prof.leaders.all().select_related("profile").order_by(DISPLAY_NAME_ORDER) | ||
| members_qs = prof.group.user_set.all().select_related("profile").order_by(DISPLAY_NAME_ORDER) |
Contributor
There was a problem hiding this comment.
For both of these, since the profile name doesn't have to be unique, we should guarantee the order for the case when multiple users have the same profile name, by adding a secondary sort column name:
.order_by(DISPLAY_NAME_ORDER, "username")
and also add a test for that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group profile page listed leaders and members in whatever order the database returned, which also made member pagination unstable across pages. Order both lists case-insensitively by the name the page actually renders: the profile's display name when set, falling back to the username, mirroring Profile.display_name.
Fixes #7270