Partial fix for Windows unit test failure, including addition of .gitattributes to resolve EOL issues#264
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesTest robustness improvements and line-ending configuration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e384077 to
157e51f
Compare
157e51f to
5cb44c0
Compare
Original issue: #218
Further discussion with @peteski22 on PR: #221
(I note that CONTRIBUTING.md suggests following a PR template, but I'm not sure where to find that).
This PR fixes some issues identified as part of investigating reinstating Windows support. There are many failing unit tests on Windows. This PR aims to clears up some of the noise leaving only the tests relating to the core permission issues failing on Windows (see discussion linked above).
Update 21/06
Path construction fix split to a separate PR.
Summary by CodeRabbit
Tests
Chores