Repository navigation
fix: gate qualified unsupported regex and Decimal calls (313) - #393
Merged
Merged
Conversation
discreteds
marked this pull request as ready for review
October 15, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Verification
MySQL verification and limits
The owner clarified that disposable test/spike adapters are allowed; the no-patches restriction applies to package code. With a process-local
pymysql.install_as_MySQLdb()alias in the existing MySQL test environment, a real Ibis 12.0.0 MySQL Backend and bound DatabaseTable now exercise the public compile path: DECIMAL_CAST raises the expected BackendCapabilityError and the unaffected LOWER expression compiles to MySQL SQL. No package or test-suite files were patched, no database connection was opened, and no adapter persists after the subprocess exits.The public compiler verification blocker is cleared. This is not standard mysqlclient qualification or new live MariaDB result qualification. Context-dependent findings from 313 remain open and are not completed by this batch.