Cleaning up time package api - #321
Open
kaashyapan wants to merge 3 commits into
Open
kaashyapan wants to merge 3 commits into
kaashyapan wants to merge 3 commits into
Conversation
Cleaup some apis of the time package. add json traits to types missing them
kaashyapan
force-pushed
the
fix-time-api
branch
from
September 12, 2026 13:21
1c64ca3 to
3776688
Compare
Contributor
Author
|
All date time types now have similar api and implement the same traits. The api surface has been borrowed from temporal. The existing ZonedDateTime does not have a complete proper validation and a complete implementation yet. The same has been flagged in the Readme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Json traits to ZonedDateTime.