feat: identify completed build output - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clients that capture output from multiple concurrently executed builds need to attribute each output chunk to the build that produced it. The existing progress callback exposes only the output text, so that provenance is lost at the n2 boundary.
What changed
BuildOutputCallbackreceiving bothBuildIdand captured outputnew_with_build_outputconstructors for dumb and fancy console progressnewconstructors by adapting their text-only callbacksWhy this is correct and minimal
Progress::task_finishedalready receives the authoritativeBuildIdtogether with the matchingTaskResult, so the callback forwards existing information without reconstructing identity. Execution, scheduling, capture, and default console behavior are unchanged, and existing callers remain source-compatible.