refactor: separate package discovery from solving - #2241
Merged
Merged
Conversation
Changed Files
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Package-selection helpers currently require
ResolveOutputeven when they only inspect module and package declarations. IntroduceDiscoveredProjectand separate discovery from package dependency solving for normal and single-file projects. Declaration-only helpers now accept this type;ResolveOutputowns it alongside the existing single dependency graph.Capture the coverage setting during discovery so source injection and graph solving stay consistent. The existing resolution entry points still complete both phases before command selection and planning, preserving command behavior and dependency-error ordering. This extracts a prerequisite from #2220; conditional-import behavior stays in that feature PR.
Add a regression test demonstrating that package selection works on declarations with an unresolved import, which is rejected when solving the graph. Existing snapshots are unchanged.
Validation
cargo test --locked -p moonbuild-rupes-recta: 99 passed.moontests: 58 unit tests and 15 integration tests passed, covering planner snapshots, package selection, prebuild watch paths, coverage, alias/cycle diagnostics, package-tree output, and single-file resolution.cargo clippy --workspace --exclude moonrun --locked --all-targets --all-features -- -D warningscargo fmt --all -- --checkandgit diff --checkMetadata