refactor(moonutil): convert package DSL directly to MoonPkg - #2238
Merged
Merged
Conversation
Changed Files
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Yu-zh
marked this pull request as draft
September 20, 2026 07:07
Yu-zh
marked this pull request as ready for review
September 20, 2026 08:37
Yu-zh
force-pushed
the
Yu-zh/direct-dsl-package
branch
from
September 21, 2026 04:01
398265e to
89baf09
Compare
peter-jerry-ye
enabled auto-merge
September 21, 2026 04:05
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moon.pkgconversion currently reconstructs aMoonPkgJSONbefore producingMoonPkg, coupling DSL conversion to the legacy JSON package schema. Decode the normalized DSL fields directly intoMoonPkg, while retaining the existingDslrepresentation and the separate converter formoon.pkg.json.Normalize declarations and legacy option overrides in one helper, then read the resulting map immutably. Field decoding deserializes borrowed values and preserves option aliases, type checks, and duplicate-field errors. Share package-kind resolution, formatter defaults, import warnings, and rule validation between the two converters.
Compatibility tests compare package values, supported-target declaration metadata, and warnings across equivalent DSL and JSON inputs.
Validation:
cargo test --locked -p moonutil: 293 passed; one existing ignored doctest.test_moon_pkg_normalizes_import_blocks: actual Wasm execution and generated-C dry-run coverage.cargo clippy -p moonutil --locked --all-targets --all-features -- -D warnings.cargo fmt --all -- --checkandgit diff --check.