refactor(tls): remove redundant Wasm connection null checks - #611
Merged
Guest0x0 merged 1 commit intoSep 17, 2026
Merged
Conversation
Guest0x0
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wasm TLS wrapper checks connection handles against literal zero, although
tls/connection/newreturns a live pending object. TLS initialization happens in the client and server setup calls, which report failures through a status and the object's error message. The null check and global-error path therefore cannot handle a constructor failure.Call the constructor and free import directly, remove the unused connection-null and global-error helpers, and document the constructor contract. This changes one Wasm implementation file and preserves the public API, setup error handling, and null checks for certificate and channel-binding buffers.
Companion cleanup for moonbitlang/moon#2222. Merge the Moonrun change first; existing guest wrappers work with it, and the simplified wrapper uses the same constructor and cleanup imports.