Skip to content

fix: add file that CI is trying to create via a commit - #207

Merged
Ahajha merged 2 commits into
modular:mainfrom
sstadick:fix/failed_commits
Feb 3, 2026
Merged

Ahajha merged 2 commits into
modular:mainfrom
sstadick:fix/failed_commits

Conversation

@sstadick

@sstadick sstadick commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

When the new target was added it triggered the creation of a new failed-compatibility-* file via CI.

CI tries to diff the failed-compat files and commit any new failures. We've never had something fail the compat check, so nothing has ever tried to add to those files. CI tries commit the changes, but the repo permissions disallow commits directly to main. Example failed job: https://github.com/modular/modular-community/actions/runs/21632682673/job/62349367247 (cc @bgreni this is why your build failed).

I think just adding this file will let things continue, but a better fix should be figured out. Either changing the repo permissions to let CI work, or finding some other way to deal with the compat check.

Jobs that have failed in this way:

@sstadick
sstadick requested a review from Ahajha February 3, 2026 14:44
@sstadick sstadick self-assigned this Feb 3, 2026
@sstadick sstadick changed the title fix: add file that CI is trying to create a commit fix: add file that CI is trying to create via a commit Feb 3, 2026

@Ahajha Ahajha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems like a reasonable stopgap

@Ahajha
Ahajha merged commit 14cf4b8 into modular:main Feb 3, 2026
2 checks passed
@sstadick
sstadick deleted the fix/failed_commits branch February 3, 2026 14:52
forfudan pushed a commit to forfudan/modular-community that referenced this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants