[feat] add rsLoRA support to MultiLoRA#187
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements Rank-Stabilized LoRA (rsLoRA) scaling logic across the linear, embedding, and Megatron forward methods. The reviewer recommends simplifying the scaling calculation with a ternary operator and abstracting the logic to reduce code duplication. A bug was also identified in the embedding forward pass where the LoRA configuration is initialized using an incorrect reference.
|
Hi, there are some gemini comments to be resolved |
Thanks for the feedback. I've refactored the rsLoRA scaling logic to use a ternary operator. |
|
Can you please run |
Thanks for the feedback. All |
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).