Avoid configuring logging during MCPServer initialization#2503
Open
fungi8 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Avoid configuring logging during MCPServer initialization#2503fungi8 wants to merge 1 commit intomodelcontextprotocol:mainfrom
fungi8 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
fungi8
force-pushed
the
fix-mcpserver-logging-side-effect
branch
from
570ec6e to
57b9340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure_logging()call fromMCPServer.__init__()so constructing a server does not mutate application-level loggingMCPServer()does not calllogging.basicConfig()Fixes #1656
Tests
uv run --frozen pytest tests/server/mcpserver/test_server.py::test_create_server_does_not_configure_logging tests/server/mcpserver/test_server.py::TestServer::test_create_server tests/server/mcpserver/utilities/test_logging.py -quv run --frozen ruff check src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_server.py tests/server/mcpserver/utilities/test_logging.pyuv run --frozen ruff format --check src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_server.py tests/server/mcpserver/utilities/test_logging.pyuv run --frozen coverage erase && uv run --frozen coverage run -m pytest tests/server/mcpserver/test_server.py::test_create_server_does_not_configure_logging tests/server/mcpserver/test_server.py::TestServer::test_create_server tests/server/mcpserver/utilities/test_logging.py && uv run --frozen coverage combine && uv run --frozen coverage report --include='src/mcp/server/mcpserver/server.py,src/mcp/server/mcpserver/utilities/logging.py' --fail-under=0 && UV_FROZEN=1 uv run --frozen strict-no-coveruv run --frozen pyright src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_server.py tests/server/mcpserver/utilities/test_logging.py