fix: Revert the create_and_start_charge_point helper function#766
Open
a-alak wants to merge 1 commit into
Open
fix: Revert the create_and_start_charge_point helper function#766a-alak wants to merge 1 commit into
a-alak wants to merge 1 commit into
Conversation
Deleted the function. Updated central system examples to not use the function.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Deleted the function. Updated central system examples to not use the function.
Current behavior
The create_and_start_charge_point helper function is broken. If you are implementing a CSMS that is only handling incoming messages and you use the
websocketslibrary, it might be usable. But if you need to send central system initiated messages, you will loose the ChargePoint instance and not be able to interact with it.I do not think this function belong here. It will create unnecessary friction for new users, that will spend a lot of time figuring out how to use and realising it is unusable if they need to track the ChargePoint instances.
Problems:
ChargePointinstance after connection terminationwebsocketslibrarySee PR #752
New behavior
The helper function is deleted and users are expected to instantiate the
ChargePointobject and run the listener loop (cp.start()).Impact
Breaking change:
create_and_start_charge_point()is no longer available, use these 5 lines instead:Or something more suitable for your needs.
Checklist