Repository navigation
Let submissions create supply system_power.json, and warn when runs lack it - #147
Merged
Merged
Conversation
…ack it submissions create builds the bundle from the uploaded run archives only. A system_power.json kept in the submitter's local results/<system>/ tree, where a finished submission holds it, never reaches the bundle, so the checker reports it missing while check-submission passes locally. - submissions create --system-power PATH supplies the descriptor for runs registered without one (single-system submissions only); also exposed through the MCP create_submission tool. - When the checker fails with a system lacking the descriptor, create explains that it reads only from the run archives and names the two fixes. - runs create warns on stderr when the run folder has no system_power.json, and points out a copy one level up that would not be uploaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
submissions createcan fail withMissing system_power.json for results/<system>even thoughcheck-submissionon the submitter's local tree passes.submissions createbuilds the bundle from the uploaded run archives only. The builder takessystem_power.jsonfrom besidepoint.yamlin each archive. A descriptor kept only in a localresults/<system>/folder, where a finished submission holds it, never reaches the bundle. Nothing along the way flags this:runs createtreats the file as optional.Changes
submissions create --system-power PATH: supplies the descriptor for runs registered without one, so runs don't have to be re-registered. It overrides the runs' copies and is refused when the runs span more than one system. It is also available through the MCPcreate_submissiontool.system_power.json,createexplains that the build reads only from the run archives and names both fixes.runs createwarning: printed on stderr, so--dry-runJSON stays clean, when the run folder has nosystem_power.json. When a copy sits one level up, the warning points to it. This can't be an error, because the division isn't known untilsubmissions create.usage/submissions.md,usage/runs.md.Testing
power-descriptorerror plus the new hint. With--system-power, the descriptor lands atresults/<system>/and the checker reports no errors.🤖 Generated with Claude Code