Fix eigh UPLO and zero-size eigh/svd on the CPU#3834
Open
kapellirohith wants to merge 1 commit into
Open
Conversation
eigh read the opposite triangle from what UPLO asked for: the row-major buffer is handed to LAPACK, which reads it as its transpose, so UPLO="L" used the upper triangle. Only observable when the two triangles differ. Also fix crashes for zero-size inputs to eigh and svd: LAPACK rejects lda = 0 and the batch-count division was by zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
eigh/eigvalshread the opposite triangle from whatUPLOasks for.The row-major buffer is handed to LAPACK, which reads it as its transpose,
so
UPLO="L"actually used the upper triangle. Only observable when thetwo triangles differ:
Also fixes crashes for zero-size inputs to
eighandsvd: LAPACKrejects
lda = 0and the batch-count division was by zero.No behavior change for inputs with consistent triangles (symmetric or
Hermitian), which is why the existing tests didn't catch it.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes