Big Update for Packagist Preparation and code Update#3
Open
nhalstead wants to merge 6 commits into
Open
Conversation
mp3file.class.php -> class.mp3file.php
class.mp3file.php: In this commit I have added a Shorthand Function that you can get the duration just by using `MP3File::getTime("myfile.mp3")` also I have updated the code by making it look neater and added comments to different sections that I can identify their actions.
composer.json: Updated the description, Added Keywords, Added License Type and Added the Repository Reference.
This repos should be ready to be added to the Packagist Page with this update.
In this commit the repos should be ready for Packagist. I have moved the Code into the src folder and I have made the class aparat of the MP3File namespace and the class remains MP3File. The `composer.json` file has been updated with the PSR4 autoload method and testing was done to verify it does work. `vendor\*` was for testing. `vendor\test.php` has a test setup to check for the MP3File class is loaded. I've added myself as an author since I have been doing updates to the repos. It can be taken out in the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request you will find a new layout of the code that has comments in it for the class as well as its in a namespace. I have changed it so the code repository is ready to be added to packagist with just a few clicks. I got all of the work done and setup for you, you @mk-j can just goto the site packagist submit and paste in your repos link (
https://github.com/mk-j/PHP_MP3_Duration) and add your repos to Composer as a package that everyone can use with ease.If you look through the code repos you will see all of the changes I have made and the updates to the composer.json, The original file is found as
src/class.mp3file.phpthevenderfolder is just composer for the testing I was doing, that I left.Thank you for figuring out all of this, this class has helped me so I am paying it forward and helping you out to get the package in packagist or composer people to use it too. Your code and your repos not on packagist but someone who has copied your code and made a packagist package are online as a package.
Thanks, Looking forward for your response.
~ Noah Halstead