Implement option to add only selected items to backpack#147
Open
LappiLappland wants to merge 2 commits into
Open
Implement option to add only selected items to backpack#147LappiLappland wants to merge 2 commits into
LappiLappland wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #137
Proposed Changes
Added
backpackOnlySelectedoption (by default false). With option enabled:Reason for Changes
This seems like a more reasonable behaviour for backpacking
Test Coverage
Added tests to verify behaviour when option is OFF and ON
I had to modify
index.jsfile to exposewindow.multiselectPluginDocumentation
I have updated README.md with option description
Additional Information
I think this could be very well
trueby defaultI did not update dragging block onto backpack behaviour as it seems reasonable to save entire chain, since you do drag entire chain
Code
cleanFlyoutInfois taken from backpack plugin repository. We can call this as a method on backpack directly in Blockly 12. Unfortunately, it's not available in Blockly 11 version