Fix shadow block deselecting main block during multiselect#142
Open
LappiLappland wants to merge 1 commit into
Open
Fix shadow block deselecting main block during multiselect#142LappiLappland wants to merge 1 commit into
LappiLappland wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #139
Proposed Changes
Added filtering for shadow blocks during selection
Reason for Changes
Selecting shadow block should select its parent. Since during drag selection both parent and shadow block might end up inside the selection, we may end up calling update on the same block twice without any way to track if it was checked already. It's best if we just filter out shadow blocks early
Test Coverage
This is only multiselect behaviour's. Added 2 tests:
Documentation
N/A
Additional Information
N/A