Skip to content

Add regression tests for block bounds selection#138

Merged
HollowMan6 merged 1 commit into
mit-cml:mainfrom
mjgallag:add-regression-tests-for-block-bounds-selection
May 18, 2026
Merged

Add regression tests for block bounds selection#138
HollowMan6 merged 1 commit into
mit-cml:mainfrom
mjgallag:add-regression-tests-for-block-bounds-selection

Conversation

@mjgallag

@mjgallag mjgallag commented May 15, 2026

Copy link
Copy Markdown
Contributor

Confirms the empty space bug and parent filter mitigation for #56.

Confirms the empty space bug and parent filter mitigation for mit-cml#56.
@mjgallag mjgallag force-pushed the add-regression-tests-for-block-bounds-selection branch from 80928b9 to 8e7f515 Compare May 15, 2026 20:07
@mjgallag mjgallag marked this pull request as draft May 15, 2026 21:26
@mjgallag mjgallag marked this pull request as ready for review May 15, 2026 21:57
@mjgallag mjgallag marked this pull request as draft May 16, 2026 17:28
@mjgallag

Copy link
Copy Markdown
Contributor Author

Since 12 will hopefully be merging late spring/early summer when it lands in App Inventor I'm just going to do this in that pull: c85deef

@mjgallag mjgallag closed this May 16, 2026
@mjgallag mjgallag deleted the add-regression-tests-for-block-bounds-selection branch May 16, 2026 17:49
@mjgallag mjgallag restored the add-regression-tests-for-block-bounds-selection branch May 18, 2026 14:41
@mjgallag mjgallag reopened this May 18, 2026
@mjgallag mjgallag marked this pull request as ready for review May 18, 2026 15:05
@mjgallag

mjgallag commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Changed my mind, I want to try to keep #133 true to Update to Blockly 12 even if it means a bit more merging from main.

@HollowMan6 this one should be good to merge!

@HollowMan6 HollowMan6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HollowMan6 HollowMan6 merged commit 2ae8432 into mit-cml:main May 18, 2026
2 checks passed
@mjgallag mjgallag deleted the add-regression-tests-for-block-bounds-selection branch May 18, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants